Generate flexible array members the c99 way instead of the GNU way #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
2f376eb
to
05cde18
Compare
emilio
reviewed
Aug 15, 2024
tests/rust/struct.rs
Outdated
| #[repr(C)] | ||
| struct WithFlexibleArrayMember { | ||
| x: i32, | ||
| y: [i8; 0], |
There was a problem hiding this comment.
Can you test with some other field afterwards too? Not sure what the behavior there should be, maybe it's fine.
There was a problem hiding this comment.
I had to rework the whole approach. I've added a specific type to represent flexible array members, and that makes everything much more consistent.
I'm unsure about the idiomaticity of my rust code, don't hesitate to bash me :-)
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
05cde18
to
2b2e64b
Compare
|
@emilio even if that change is correct from a compiler point of view, it would actually break mozilla code if gnu behavior is of by default because the firefox codebase is making an optimistic use of flexible array members. I guess it's still good to merge this, but with gnu behavior on by default. What do you think? |
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
2b2e64b
to
4697c73
Compare
There a re three ways to express flexible array members: 1. char fam[0]; 2. char fam[1]; 3. char fam[]; 3. is the only standard way (in c99, but supported in c++ as an extension), the other two are GNU syntax (still supported in clang though). To avoid regression, let's generate the GNU syntax by default, while leaving it possible to use 3. through struct.c99_flexible_array_members Cython only supports the 1. mode.
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
4697c73
to
ff2e4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There a re three ways to express flexible array members:
char fam[0];
char fam[1];
char fam[];
is the only standard way (in c99, but supported in c++ as an extension), the other two are GNU syntax (still supported in clang though).
Let's generate the standard syntax by default, while leaving it possible to use 1. through struct.gnu_flexible_array_members
Cython only supports the 1. mode.